fix: specify utf-8 encoding when reading README.md in setup.py - #30
Open
mmaxjr wants to merge 1 commit into
Open
fix: specify utf-8 encoding when reading README.md in setup.py#30mmaxjr wants to merge 1 commit into
mmaxjr wants to merge 1 commit into
Conversation
README.md contains non-ASCII characters, but setup.py opened it with open()'s platform-default encoding. On systems where that default is ASCII (e.g. minimal Docker images with a C/POSIX locale), pip install failed with UnicodeDecodeError before setup.py could even run. Fixes daveoncode#17 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17
Problem
README.mdhas non-ASCII characters, butsetup.pyopened it withoutspecifying an encoding, relying on the platform default. In environments
where that default is ASCII (e.g. a minimal Docker image with a C/POSIX
locale, as reported),
pip installfailed before setup.py could evenfinish running: